-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve] Alias ray.serve.dag.InputNode
#24630
[Serve] Alias ray.serve.dag.InputNode
#24630
Conversation
@simon-mo should we put this under |
yeah that's a good idea... from ray.serve import stuff smells a bit weird as well |
ray.serve.InputNode
ray.serve.dag.InputNode
changed |
@simon-mo should this and dagdriver come from the same import also? Depends on if we expect to have more builtin drivers in the future. |
I'm still conflicted about the driver. On the one hand the drivers package is great and signify users can just add more and more drivers. on the other hand it's surely better to have one less import line... |
…nputnode-top-level
Why are these changes needed?
Because we can't expect users to type
from ray.experimental.dag.input_node import InputNode
when Serve deployment graph hits Beta/GARelated issue number
Checks
scripts/format.sh
to lint the changes in this PR.