Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Alias ray.serve.dag.InputNode #24630

Merged
merged 6 commits into from
May 18, 2022

Conversation

simon-mo
Copy link
Contributor

Why are these changes needed?

Because we can't expect users to type from ray.experimental.dag.input_node import InputNode when Serve deployment graph hits Beta/GA

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
Copy link
Contributor

edoakes commented May 13, 2022

@simon-mo should we put this under ray.serve.dag instead? Might be better to not pollute the top-level namespace. Your call.

@simon-mo
Copy link
Contributor Author

yeah that's a good idea... from ray.serve import stuff smells a bit weird as well

@simon-mo simon-mo changed the title [Serve] Alias ray.serve.InputNode [Serve] Alias ray.serve.dag.InputNode May 13, 2022
@simon-mo
Copy link
Contributor Author

changed

@edoakes
Copy link
Contributor

edoakes commented May 13, 2022

@simon-mo should this and dagdriver come from the same import also? Depends on if we expect to have more builtin drivers in the future.

@simon-mo
Copy link
Contributor Author

I'm still conflicted about the driver. On the one hand the drivers package is great and signify users can just add more and more drivers. on the other hand it's surely better to have one less import line...

@simon-mo simon-mo merged commit 9b2086c into ray-project:master May 18, 2022
maxpumperla pushed a commit that referenced this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants