[train] Pin pytorch lightning to 2.0.4 #37400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
woshiyyya
reviewed
Jul 13, 2023
| @@ -84,6 +84,6 @@ | |||
| - PYTHON=3.8 DOC_TESTING=1 TRAIN_TESTING=1 TUNE_TESTING=1 ./ci/env/install-dependencies.sh | |||
| - pip install -Ur ./python/requirements/ml/dl-gpu-requirements.txt | |||
| - pip uninstall -y pytorch-lightning | |||
| - pip install lightning==2.0.0 | |||
| - pip install lightning==2.0.4 pytorch-lightning==2.0.4 # todo move to requirements-test.txt | |||
There was a problem hiding this comment.
Suggested change
| - pip install lightning==2.0.4 pytorch-lightning==2.0.4 # todo move to requirements-test.txt | |
| - pip install lightning==2.0.4 pytorch_lightning==2.0.4 # todo move to requirements-test.txt |
Thank you @krfricke! I checked when we install lightning==2.0.0, pip will always install the latest version of pytorch_lightning. That's why the library version has changed, which is kind of tricky. I agree to pin the version to improve the stability of ci tests.
woshiyyya
approved these changes
Jul 13, 2023
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 24, 2023
2.0.5 breaks master as the deepspeed device validation fails. We should look into this separately. Signed-off-by: Kai Fricke <kai@anyscale.com>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
2.0.5 breaks master as the deepspeed device validation fails. We should look into this separately. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
2.0.5 breaks master as the deepspeed device validation fails. We should look into this separately. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
2.0.5 breaks master as the deepspeed device validation fails. We should look into this separately. Signed-off-by: Kai Fricke <kai@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
2.0.5 breaks master as the deepspeed device validation fails. We should look into this separately. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
2.0.5 breaks master as the deepspeed device validation fails. We should look into this separately. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
2.0.5 breaks master as the deepspeed device validation fails. We should look into this separately.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.