Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] Pin pytorch lightning to 2.0.4 #37400

Merged
merged 2 commits into from
Jul 13, 2023
Merged

[train] Pin pytorch lightning to 2.0.4 #37400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c678a76
[train] Pin pytorch lightning to 2.0.4
Jul 13, 2023
322c5b0
trivial
Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.gpu_large.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@
- PYTHON=3.8 DOC_TESTING=1 TRAIN_TESTING=1 TUNE_TESTING=1 ./ci/env/install-dependencies.sh
- pip install -Ur ./python/requirements/ml/dl-gpu-requirements.txt
- pip uninstall -y pytorch-lightning
- pip install lightning==2.0.0
- pip install lightning==2.0.4 pytorch-lightning==2.0.4 # todo move to requirements-test.txt
Copy link
Member

@woshiyyya woshiyyya Jul 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- pip install lightning==2.0.4 pytorch-lightning==2.0.4 # todo move to requirements-test.txt
- pip install lightning==2.0.4 pytorch_lightning==2.0.4 # todo move to requirements-test.txt

Thank you @krfricke! I checked when we install lightning==2.0.0, pip will always install the latest version of pytorch_lightning. That's why the library version has changed, which is kind of tricky. I agree to pin the version to improve the stability of ci tests.

- ./ci/env/env_info.sh
- bazel test --config=ci $(./scripts/bazel_export_options) --test_tag_filters=ptl_v2 python/ray/train/...
2 changes: 1 addition & 1 deletion python/ray/train/lightning/_lightning_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def _session_report(self, trainer: "pl.Trainer", stage: str):
if isinstance(v, torch.Tensor):
metrics[k] = v.item()

# Ensures all workers already finish writing their checkpoints.
# Ensures all workers already finish writing their checkpoints
trainer.strategy.barrier()

# Create and report the latest checkpoint
Expand Down
Loading