Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Cherry-pick Serve enum to_proto fixes for Python 3.11 #37660

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jul 21, 2023

Why are these changes needed?

Cherry-picks the following 1-line compatibility fixes for Python 3.11:

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Python 3.11 introduces a breaking change in f-string behaviour, should be caught when switching to cp311 CI

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested review from rickyyx and aslonnie July 21, 2023 21:51
@rickyyx rickyyx merged commit 62b4a0a into ray-project:releases/2.6.1 Jul 22, 2023
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants