[Serve] Fix ApplicationStatusInfo.to_proto #37258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
ddelange
changed the title
ddelange
changed the title
edoakes
approved these changes
Jul 10, 2023
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 11, 2023
Python 3.11 introduces a breaking change in f-string behaviour, should be caught when switching to cp311 CI Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Signed-off-by: Bhavpreet Singh <singh.bhavpreet00@gmail.com>
|
hi @edoakes, I saw ray 2.6 was just released, but this merge commit is only on master 🤔 or was it included in the relase under a different commit? |
|
Temporary fix: downgrading to python=3.9 solved it. |
|
yes this is a fix specifically for python 3.11+ |
8 tasks
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 21, 2023
Python 3.11 introduces a breaking change in f-string behaviour, should be caught when switching to cp311 CI Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
8 tasks
rickyyx
pushed a commit
that referenced
this pull request
Jul 22, 2023
* [serve] Fix DeploymentStatus enum to_proto (#36954) Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> * Fix ApplicationStatusInfo.to_proto (#37258) Python 3.11 introduces a breaking change in f-string behaviour, should be caught when switching to cp311 CI Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Co-authored-by: ddelange <14880945+ddelange@users.noreply.github.com>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Python 3.11 introduces a breaking change in f-string behaviour, should be caught when switching to cp311 CI Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Python 3.11 introduces a breaking change in f-string behaviour, should be caught when switching to cp311 CI Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Python 3.11 introduces a breaking change in f-string behaviour, should be caught when switching to cp311 CI
Related issue number
Closes #36319
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.