Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix code format lint #37755

Merged
merged 3 commits into from
Jul 26, 2023
Merged

[CI] Fix code format lint #37755

merged 3 commits into from
Jul 26, 2023

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

#37566 and then #36980 broke lint. This PR fixes the errors.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this -- one comment but otherwise good to go.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@c21 c21 merged commit 6048b6b into ray-project:master Jul 26, 2023
64 checks passed
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
ray-project#37566 and then ray-project#36980 broke lint. This PR fixes the errors.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
ray-project#37566 and then ray-project#36980 broke lint. This PR fixes the errors.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
ray-project#37566 and then ray-project#36980 broke lint. This PR fixes the errors.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
ray-project#37566 and then ray-project#36980 broke lint. This PR fixes the errors.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
ray-project#37566 and then ray-project#36980 broke lint. This PR fixes the errors.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants