Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data][Docs] Standardize "Sorting, Shuffling, Repartitioning" references #36982

Merged
merged 64 commits into from
Jul 25, 2023
Merged

[Data][Docs] Standardize "Sorting, Shuffling, Repartitioning" references #36982

merged 64 commits into from
Jul 25, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jun 30, 2023 •
edited
Loading

Why are these changes needed?

This PR standardizes API references listed under "Sorting, Shuffling, Repartitioning".

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

bveeramani and others added 30 commits November 21, 2022 21:00
@bveeramani
Rename "model_state_dict" to "model"
5984f1e
@bveeramani
Revert "Rename "model_state_dict" to "model""
8f58490 
This reverts commit 5984f1e.
@bveeramani
Merge remote-tracking branch 'upstream/master'
63432eb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
2c33947 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
89694a0 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fe60ca3 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
d45ae9a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
c703dfc 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
81dd25c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fba788e 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update annotations.py
de05655 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Revert "Update annotations.py"
fd2ff91 
This reverts commit de05655.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
7c3ac36 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9c7b546 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9d7a15f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
4f02efe 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
46f43d9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
a644307 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
e5d0bf1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fe7286c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
51b3a09 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
79f8be9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
53bede6 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
7cec6e3 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9407930 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
67ae591 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
93414b8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fcfa9a5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fbfe52d 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
16132de 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as ready for review June 30, 2023 20:40
@bveeramani
Merge remote-tracking branch 'upstream/master'
40f488f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
1742f5d 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
angelinalg
angelinalg approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just some nits.

@bveeramani
Merge remote-tracking branch 'upstream/master'
d5dc07a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
amogkam
amogkam approved these changes Jul 7, 2023
View reviewed changes
python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
@bveeramani
Merge remote-tracking branch 'upstream/master'
b9cbe98 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
7050c96 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
6b658cf 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
a2a8887 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
193b9f4 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
e65c3d5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
8be7eeb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
415ec40 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Address review comments
6e07c83 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'master' into sorting-ref
13904e7 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update dataset.py
5f012a1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update dataset.py
f1391ab 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into sorting-ref
ae306aa 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Copy link
Member Author

Code format failures are from #37566 and #36980. See #37755

@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 25, 2023
@amogkam amogkam merged commit 90dac1d into ray-project:master Jul 25, 2023
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@bveeramani @NripeshN
[Data][Docs] Standardize "Sorting, Shuffling, Repartitioning" referen…
d0fc9e4 
…ces (ray-project#36982)

This PR standardizes API references listed under "Sorting, Shuffling, Repartitioning".

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@bveeramani @arvind-chandra
[Data][Docs] Standardize "Sorting, Shuffling, Repartitioning" referen…
fe9dfcf 
…ces (ray-project#36982)

This PR standardizes API references listed under "Sorting, Shuffling, Repartitioning".

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@bveeramani
[Data][Docs] Standardize "Sorting, Shuffling, Repartitioning" referen…
463a328 
…ces (ray-project#36982)

This PR standardizes API references listed under "Sorting, Shuffling, Repartitioning".

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

@amogkam amogkam amogkam approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

Assignees

@c21 c21

@amogkam amogkam

@angelinalg angelinalg

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bveeramani @amogkam @angelinalg @c21