Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified TorchTrainer] Add PyTorch Lightning Trainer Utilities #37989
[Unified TorchTrainer] Add PyTorch Lightning Trainer Utilities #37989
Changes from 11 commits
3a7dc6e
c7b91a7
4ef88c9
7b5da30
95e2b9b
4df1ec6
3914a21
21a8ce3
abdf842
d3b01f0
0ecd61a
0de4bc4
2b2589e
7c1b1e2
e8285ab
6c326a0
2f9f5a4
4f1412f
c9f3c03
8264549
ba81c15
89c7388
0d9bdaf
c186f5b
6925a05
079ddec
7c19ffe
8a65e36
9d9ed17
87aa763
74717af
a4213a2
4e06c89
1396883
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this with the original
_lightning_utils
name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it because there are still private methods/classes in that file? Should we remove the underscore after we fully deprecated LightningTrainer?