-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dolly v2 instruction fine tuning with deepspeed #38241
Add dolly v2 instruction fine tuning with deepspeed #38241
Conversation
eaa20f1
to
0761eab
Compare
@matthewdeng, @xwjiang2010 , could anyone of you please have a look at this notebook pr when you are available? I referenced this work in this medium blog post. |
@yutsai84 Thanks for contributing to our docs! Taking a look. |
@yutsai84 Thanks for the great example. I am excited to see it working on KubeRay. Actually we are going through Ray Train API redesign. The idea is to unify everything under TorchTrainer. Take a look at the REP here. ETA is to land this at 2.7 release together with Ray Train GA (general availability). Would you be open to doing a user study with us to try out the new APIs? I also think it would be great to make this the first example working on the new API. |
@xwjiang2010. Absolutely! I am more than happy to help test out your new API. I will follow closely with the 2.7 release. |
Hello everyone, this seems falling out of the radar. Would you all have any suggestion of this PR and the next step? Thanks! |
@yutsai84 sorry, I'm thinking if we could land this example using the new API. |
@xwjiang2010. That sounds great. Would you have rough timeline of the new API release (ray 2.7)? I will follow closely here too. Look forward to trying out the new API! |
Branch cut in a week and roughly another 2 weeks to go through the release process. Maybe let's revisit this PR in about 3 weeks? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
@xwjiang2010 , I just saw the release is cut for ray 2.7. Would you want to revisit this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still relevant? should we close this?
@yutsai84 apologies on the delayed review. I'm going to mark this one as closed because the |
Why are these changes needed?
This pr creates a demo for instruction fine-tuning the dolly v2 3B model with deepspeed and Ray AIR into a ray's doc repo.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.