Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dolly v2 instruction tuning ray train #40455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yutsai84
Copy link

Why are these changes needed?

This pr creates a demo for instruction fine-tuning the dolly v2 3B model with deepspeed and Ray Train into a ray's doc repo.

This is a migration from the previous pr using Ray AIR

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@yutsai84
Copy link
Author

@@xwjiang2010, this is the migration of previous notebook from Ray AIR to Ray Train. :)

@kevin85421
Copy link
Member

cc @woshiyyya @justinvyu

Would you mind taking a look when you have time? Thanks!

Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 15, 2023
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still relevant? should we close this?

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 26, 2024
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) train Ray Train Related Issue labels May 14, 2024
@anyscalesam
Copy link
Contributor

I know we reworked all of the docs for Train GA; is this still something that makes sense to be merged @matthewdeng ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
train Ray Train Related Issue triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants