Limit maximum starting workers per language #3852
Conversation
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
| /// The number of workers per process. | ||
| int num_workers_per_process_; | ||
|
|
||
| private: |
There was a problem hiding this comment.
We are we making all of the below protected instead of private? For the tests?
There was a problem hiding this comment.
I refactored the code and move some fields back to private. But I still need states_by_lang_ to be protected for tests.
src/ray/raylet/worker_pool_test.cc
Outdated
| } | ||
| // Check that number of starting worker processes equals to | ||
| // maximum_startup_concurrency_ * 2. (because we started both python and java workers) | ||
| ASSERT_EQ(worker_pool_.NumWorkerProcessesStarting(), 5 * 2); |
There was a problem hiding this comment.
Can you include a comment saying where the value 5 is initialized otherwise it is a bit out of the blue.
|
The linting Travis build seems to be failing https://travis-ci.com/ray-project/ray/jobs/173188614 |
kfstorm
force-pushed
the
initial_worker_count
branch
from
750ad1a
to
e21740c
Compare
|
Test PASSed. |
|
Test FAILed. |
kfstorm
force-pushed
the
initial_worker_count
branch
from
ef5dec0
to
a3a8013
Compare
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
What do these changes do?
Assumes that a node has 4 CPUs and we enabled both java and python workers. Before this change, raylet will start 4 java workers and 0 python workers by default at startup. After this change, raylet will start 4 java workers and 4 python workers by default at startup.
Related issue number