Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray 2.7 Examples][2/n] Revamp the GPT-J DeepSpeed Example #38600

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Aug 18, 2023

Why are these changes needed?

Revamp the GPT-J deepspeed finetuning example with new apis. The main changes are:

  • Replace TransformersTrainer with TorchTrainer + integration utilities
  • Removed the Preprocessors
  • Removed the TransformersPredictor
  • Replaced the doc links to our new user guides.
  • Replaced All Ray AIR mentions to Ray Train

Rendered doc: https://anyscale-ray--38600.com.readthedocs.build/en/38600/ray-air/examples/gptj_deepspeed_fine_tuning.html

Release test passed: https://buildkite.com/ray-project/release-tests-pr/builds/50013#018a1af2-c070-4482-a413-8632f20991ae

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya changed the title [Ray 2.7 Examples][1/n] Revamp the GPT-J DeepSpeed Example [Ray 2.7 Examples][2/n] Revamp the GPT-J DeepSpeed Example Aug 18, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@richardliaw
Copy link
Contributor

Remove all 'preprocessor' imports, now they are no longer used?

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
Copy link
Member Author

@richardliaw Done!

@woshiyyya woshiyyya added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 22, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been meaning to copy edit this notebook. I hope you are able to incorporate them in this PR without too much friction.

Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
@woshiyyya
Copy link
Member Author

@angelinalg Thank you so much for the polish! The whole example now feels much more natural and fluid!!

@xwjiang2010 xwjiang2010 merged commit eea8e89 into ray-project:master Aug 22, 2023
6 of 14 checks passed
amogkam added a commit that referenced this pull request Aug 22, 2023
Deprecates passing in preprocessor to Trainers. Also deprecates Chain and BatchMapper preprocessors. Removes all usage of preprocessors on non-tabular data from the docs and examples.

Closes #38290

Depends on #38634 and #38600

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ct#38600)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Deprecates passing in preprocessor to Trainers. Also deprecates Chain and BatchMapper preprocessors. Removes all usage of preprocessors on non-tabular data from the docs and examples.

Closes ray-project#38290

Depends on ray-project#38634 and ray-project#38600

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ct#38600)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Deprecates passing in preprocessor to Trainers. Also deprecates Chain and BatchMapper preprocessors. Removes all usage of preprocessors on non-tabular data from the docs and examples.

Closes ray-project#38290

Depends on ray-project#38634 and ray-project#38600

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants