[Train] Deprecate preprocessor arg to Trainer
#38640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
amogkam
requested review from
richardliaw,
gjoliver,
krfricke,
xwjiang2010,
matthewdeng,
Yard1,
maxpumperla,
a team,
ericl,
scv119,
c21,
scottjlee,
bveeramani,
raulchen,
justinvyu and
sofianhnaide
as code owners
…ay into deprecate-preprocessor-trainer
…ay into deprecate-preprocessor-trainer
matthewdeng
approved these changes
Aug 21, 2023
doc/source/ray-air/examples/huggingface_text_classification.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
ericl
added
the
@author-action-required
…ay into deprecate-preprocessor-trainer
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
…eprocessor-trainer Signed-off-by: amogkam <amogkamsetty@yahoo.com>
amogkam
force-pushed
the
deprecate-preprocessor-trainer
branch
from
336cadd
to
92164e0
Compare
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
…eprocessor-trainer Signed-off-by: amogkam <amogkamsetty@yahoo.com>
|
Failing tests are unrelated. Going to merge. |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Deprecates passing in preprocessor to Trainers. Also deprecates Chain and BatchMapper preprocessors. Removes all usage of preprocessors on non-tabular data from the docs and examples. Closes ray-project#38290 Depends on ray-project#38634 and ray-project#38600 --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com> Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Deprecates passing in preprocessor to Trainers. Also deprecates Chain and BatchMapper preprocessors. Removes all usage of preprocessors on non-tabular data from the docs and examples. Closes ray-project#38290 Depends on ray-project#38634 and ray-project#38600 --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com> Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
8 tasks
justinvyu
added a commit
that referenced
this pull request
Feb 14, 2024
This PR removes the hard-deprecated `preprocessor` argument fully. This is a follow-up to #38640. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
kevin85421
pushed a commit
to kevin85421/ray
that referenced
this pull request
Feb 17, 2024
…t#43146) This PR removes the hard-deprecated `preprocessor` argument fully. This is a follow-up to ray-project#38640. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates passing in
preprocessortoTrainers. Also deprecatesChainandBatchMapperpreprocessors. Removes all usage of preprocessors on non-tabular data from the docs and examples.Closes #38290
Depends on #38634 and #38600
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.