Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray 2.7 Examples][3/n] Delete Obsolete Transformers GLUE Example #38682

Merged

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Aug 21, 2023

Why are these changes needed?

We clean up this outdated example which uses AccelerateTrainer API.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/docs/checkouts/readthedocs.org/user_builds/anyscale-ray/checkouts/38682/doc/source/train/examples.rst:: WARNING: toctree contains reference to nonexisting document 'train/examples/transformers/transformers_example' [etoc.ref]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brutal PR by @woshiyyya but a necessary one. I plead everyone to keep this one alive in our memories at least.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that I buried a memorable history here 😹 We'll remember it.

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krfricke we're removing this example, which seems to be the only one included in the new persistence mode CI tests right now.

Can you help determine the right next step for this (maybe disable the test suite until more tests are migrated) and help merge this PR after? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. @woshiyyya can you just comment out the test job in the .buildkite/pipeline.ml.yml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure. I'll add a TODO() and tag you there~

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@krfricke krfricke merged commit bde33fa into ray-project:master Aug 23, 2023
42 of 44 checks passed
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…y-project#38682)

We clean up this outdated example which uses AccelerateTrainer API.

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…y-project#38682)

We clean up this outdated example which uses AccelerateTrainer API.

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants