-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray 2.7 Examples][3/n] Delete Obsolete Transformers GLUE Example #38682
[Ray 2.7 Examples][3/n] Delete Obsolete Transformers GLUE Example #38682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/home/docs/checkouts/readthedocs.org/user_builds/anyscale-ray/checkouts/38682/doc/source/train/examples.rst:: WARNING: toctree contains reference to nonexisting document 'train/examples/transformers/transformers_example' [etoc.ref]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brutal PR by @woshiyyya but a necessary one. I plead everyone to keep this one alive in our memories at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that I buried a memorable history here 😹 We'll remember it.
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
…e_transformers_example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krfricke we're removing this example, which seems to be the only one included in the new persistence mode CI tests right now.
Can you help determine the right next step for this (maybe disable the test suite until more tests are migrated) and help merge this PR after? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. @woshiyyya can you just comment out the test job in the .buildkite/pipeline.ml.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sure. I'll add a TODO()
and tag you there~
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
…e_transformers_example
…y-project#38682) We clean up this outdated example which uses AccelerateTrainer API. Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
…y-project#38682) We clean up this outdated example which uses AccelerateTrainer API. Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Why are these changes needed?
We clean up this outdated example which uses
AccelerateTrainer
API.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.