Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray 2.7 Examples][3/n] Delete Obsolete Transformers GLUE Example #38682

Merged
merged 5 commits into from
Aug 23, 2023
Merged

[Ray 2.7 Examples][3/n] Delete Obsolete Transformers GLUE Example #38682

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
269bedc
wip
woshiyyya Aug 21, 2023
a114573
update toc
woshiyyya Aug 21, 2023
a1a3cb8
Merge remote-tracking branch 'upstream/master' into doc/delete_outdat…
woshiyyya Aug 21, 2023
b1795d5
comment out persistence test suite
woshiyyya Aug 22, 2023
141c14b
Merge remote-tracking branch 'upstream/master' into doc/delete_outdat…
woshiyyya Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions doc/source/ray-overview/examples.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,13 +564,6 @@ Ray Examples

PyTorch Fashion MNIST Training Example

.. grid-item-card:: :bdg-secondary:`Code example`
:class-item: gallery-item pytorch training train
:link: train_transformers_example
:link-type: ref

Transformers with PyTorch Training Example

.. grid-item-card:: :bdg-secondary:`Code example`
:class-item: gallery-item tensorflow training train
:link: tensorflow_mnist_example
Expand Down
8 changes: 0 additions & 8 deletions doc/source/train/examples.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ Distributed Training Examples using Ray Train

PyTorch Fashion MNIST Training Example

.. grid-item-card::
:img-top: /images/hugging.png
:class-img-top: pt-2 w-75 d-block mx-auto fixed-height-img

.. button-ref:: train_transformers_example

Transformers with PyTorch Training Example

.. grid-item-card::
:img-top: /images/tf_logo.png
:class-img-top: pt-2 w-75 d-block mx-auto fixed-height-img
Expand Down
8 changes: 0 additions & 8 deletions doc/source/train/examples/transformers/transformers_example.rst
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/home/docs/checkouts/readthedocs.org/user_builds/anyscale-ray/checkouts/38682/doc/source/train/examples.rst:: WARNING: toctree contains reference to nonexisting document 'train/examples/transformers/transformers_example' [etoc.ref]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brutal PR by @woshiyyya but a necessary one. I plead everyone to keep this one alive in our memories at least.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that I buried a memorable history here 😹 We'll remember it.

This file was deleted.

24 changes: 0 additions & 24 deletions python/ray/train/BUILD
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krfricke we're removing this example, which seems to be the only one included in the new persistence mode CI tests right now.

Can you help determine the right next step for this (maybe disable the test suite until more tests are migrated) and help merge this PR after? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. @woshiyyya can you just comment out the test job in the .buildkite/pipeline.ml.yml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure. I'll add a TODO() and tag you there~

Original file line number Diff line number Diff line change
Expand Up @@ -75,30 +75,6 @@ py_test(
deps = [":train_lib"]
)

py_test(
name = "transformers_example_gpu",
size = "medium",
main = "examples/transformers/transformers_example.py",
srcs = ["examples/transformers/transformers_example.py"],
tags = ["team:ml", "exclusive", "tune", "gpu_only"],
deps = [":train_lib"],
args = ["--model_name_or_path=bert-base-cased", "--task_name=mrpc",
"--max_length=32", "--per_device_train_batch_size=64",
"--max_train_steps=2", "--start_local", "--num_workers=2", "--use_gpu"]
)

py_test(
name = "transformers_example_cpu",
size = "medium",
main = "examples/transformers/transformers_example.py",
srcs = ["examples/transformers/transformers_example.py"],
tags = ["team:ml", "exclusive", "tune"],
deps = [":train_lib"],
args = ["--model_name_or_path=bert-base-cased", "--task_name=mrpc",
"--max_length=32", "--per_device_train_batch_size=64",
"--max_train_steps=2", "--start_local", "--num_workers=2"]
)

py_test(
name = "tune_cifar_torch_pbt_example",
size = "medium",
Expand Down
57 changes: 0 additions & 57 deletions python/ray/train/examples/transformers/README.rst
View file
Open in desktop

This file was deleted.

Empty file removed python/ray/train/examples/transformers/__init__.py
View file
Open in desktop
Empty file.
58 changes: 0 additions & 58 deletions python/ray/train/examples/transformers/cluster.yaml
View file
Open in desktop

This file was deleted.

Loading
Loading