Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air] New train.Checkpoint API: Update Train tests + examples (batch 3 - test_*_trainer) #38759

Merged
merged 9 commits into from
Aug 23, 2023
Merged

[air] New train.Checkpoint API: Update Train tests + examples (batch 3 - test_*_trainer) #38759

merged 9 commits into from
Aug 23, 2023

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Aug 22, 2023 •
edited

Why are these changes needed?

This PR mainly updates the trainer unit tests.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@justinvyu
test_data_parallel_trainer
a9e7b4a 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_data_parallel_trainer_checkpointing
b6686e0 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_mosaic_trainer
890812b 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_tensorflow_trainer
1592982 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
[test_base_trainer] port over preprocessor removal PR changes
680ea69 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
[test_base_trainer] finish
85faa15 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
test_checkpoint_manager (move_only)
a3ed80a 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 22, 2023
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into air/…
76a7032 
…persistence/ci/train3

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
deflake test_tf_trainer
d8d970e 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Aug 23, 2023
@justinvyu
Copy link
Contributor Author

@krfricke Ok to merge.

@krfricke krfricke merged commit 78d6ef1 into ray-project:master Aug 23, 2023
43 of 45 checks passed
@justinvyu justinvyu deleted the air/persistence/ci/train3 branch August 23, 2023 17:28
@krfricke krfricke mentioned this pull request Aug 24, 2023
Merged
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@justinvyu @arvind-chandra
[air] New train.Checkpoint API: Update Train tests + examples (ba…
373e384 
…tch 3 - `test_*_trainer`) (ray-project#38759)

This PR mainly updates the trainer unit tests.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@justinvyu
[air] New train.Checkpoint API: Update Train tests + examples (ba…
9ec4646 
…tch 3 - `test_*_trainer`) (ray-project#38759)

This PR mainly updates the trainer unit tests.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@krfricke krfricke krfricke approved these changes

Assignees

@ericl ericl

@krfricke krfricke

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinvyu @ericl @krfricke