[ci] Reduce train tests+examples parallelism #38820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2023 10:31
Signed-off-by: Kai Fricke <kai@anyscale.com>
zhe-thoughts
approved these changes
Aug 24, 2023
|
@matthewdeng can you give a green light here before I merge? |
matthewdeng
approved these changes
Aug 24, 2023
| @@ -32,7 +32,7 @@ | |||
| - label: ":steam_locomotive: Train tests and examples" | |||
| conditions: ["NO_WHEELS_REQUIRED", "RAY_CI_TRAIN_AFFECTED"] | |||
| instance_size: large | |||
| parallelism: 4 | |||
| parallelism: 3 | |||
There was a problem hiding this comment.
What's the end state here for 2.7? Are we going to delete this step once they're all moved to the new persistence path?
There was a problem hiding this comment.
We aim to flick the switch to on per default and then remove the duplicate steps
krfricke
added
the
tests-ok
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
* [ci] Reduce train tests+examples parallelism Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
* [ci] Reduce train tests+examples parallelism Signed-off-by: Kai Fricke <kai@anyscale.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
* [ci] Reduce train tests+examples parallelism Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The "Train tests and examples" pipeline is being thinned out in scope of the storage API refactor. After #38759 was merged, one of the jobs doesn't contain any tests anymore. This is not correctly detected by the sharding script, so bazel complains about an empty test suite.
This PR reduces the parallelism of this job so that it's not empty anymore. This does not change any Ray code. (There's only a trivial change to trigger testing).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.