[Train] Convert All doc tests and examples to use new Checkpoint API #38859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvyu
reviewed
Aug 25, 2023
| model_state=net.state_dict(), | ||
| optimizer_state=optimizer.state_dict(), | ||
| epoch=epoch, | ||
| ) | ||
| ) | ||
| train.report(dict(loss=running_loss / epoch_steps), checkpoint=checkpoint) | ||
| torch.save(state_dict, f"{tmpdir}/checkpoint.bin") |
There was a problem hiding this comment.
can we only use os.path.join for all examples?
There was a problem hiding this comment.
Hopefully that's easy to do with find and replace 😅
There was a problem hiding this comment.
ahh ok. Let me replace them,
| "\n", | ||
| "checkpoint = LegacyTransformersCheckpoint.from_checkpoint(result.checkpoint)\n", | ||
| "checkpoint = TransformersCheckpoint.from_checkpoint(result.checkpoint)\n", |
There was a problem hiding this comment.
This needs to be TransformersCheckpoint(path=result.checkpoint.path, filesystem=result.checkpoint.filesystem)
woshiyyya
commented
Aug 25, 2023
doc/source/ray-air/examples/huggingface_text_classification.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
krfricke
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Convert most Ray Train/AIR/Tune examples and doc code to use new Checkpoint API.
We need to fix the rest in the following PR:
doc/source/train/examples/lightning/lightning_cola_advanced.ipynb: LightningTrainer -> TorchTrainerdoc/source/ray-air/examples/dolly_lightning_fsdp_finetuning.ipynb: Fix release testdoc/source/ray-air/examples/lightgbm_example.ipynbdoc/source/ray-air/examples/xgboost_example.ipynbdoc/source/tune/examples/tune_analyze_results.ipynbRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.