Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] [KubeRay] Add GKE ingress doc #38935

Merged
merged 7 commits into from Aug 29, 2023
Merged

[Doc] [KubeRay] Add GKE ingress doc #38935

merged 7 commits into from Aug 29, 2023

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni
Add GKE ingress doc
9a1b57b 
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni
Update prerequisites
26f6286 
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni
Fix
d246f93 
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni
Fix
34f7bbc 
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
angelinalg
angelinalg approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit for style. Sneak peek: You can use the Vale linter to check for style. See go/vale.

doc/source/cluster/kubernetes/k8s-ecosystem/ingress.md Outdated Show resolved Hide resolved
architkulkarni and others added 2 commits August 28, 2023 15:06
@architkulkarni @angelinalg
Will allocate -> allocates
2e154d3 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni
Merge branch 'master' into gke-ingress
72085d0
kevin85421
kevin85421 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/source/cluster/kubernetes/k8s-ecosystem/ingress.md Outdated Show resolved Hide resolved
@architkulkarni @kevin85421
Update doc/source/cluster/kubernetes/k8s-ecosystem/ingress.md
ad555fb 
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni architkulkarni merged commit 8c45d78 into ray-project:master Aug 29, 2023
15 checks passed
architkulkarni added a commit to architkulkarni/ray that referenced this pull request Aug 29, 2023
@architkulkarni @angelinalg @kevin85421
[Doc] [KubeRay] Add GKE ingress doc (ray-project#38935)
3ce70a2 
Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
@GeneDer GeneDer mentioned this pull request Aug 29, 2023
Merged
8 tasks
GeneDer pushed a commit that referenced this pull request Aug 29, 2023
@architkulkarni @angelinalg @kevin85421
[Doc] [KubeRay] Add GKE ingress doc (#38935) (#39073)
384e201 
Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@architkulkarni @angelinalg
@kevin85421 @arvind-chandra
[Doc] [KubeRay] Add GKE ingress doc (ray-project#38935)
90b7670 
Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
@architkulkarni @angelinalg
@kevin85421 @LeonLuttenberger
[Doc] [KubeRay] Add GKE ingress doc (ray-project#38935)
612255e 
Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@architkulkarni @angelinalg
@kevin85421 @jimthompson5802
[Doc] [KubeRay] Add GKE ingress doc (ray-project#38935)
6d073c7 
Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@architkulkarni @angelinalg @kevin85421
[Doc] [KubeRay] Add GKE ingress doc (ray-project#38935)
b4bed15 
Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

@angelinalg angelinalg angelinalg approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@architkulkarni @kevin85421 @angelinalg