Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] [KubeRay] Add GKE ingress doc (#38935) #39073

Merged
merged 1 commit into from Aug 29, 2023
Merged

[Doc] [KubeRay] Add GKE ingress doc (#38935) #39073

merged 1 commit into from Aug 29, 2023

Conversation

architkulkarni
Copy link
Contributor

(Cherry pick) Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni @angelinalg @kevin85421
[Doc] [KubeRay] Add GKE ingress doc (ray-project#38935)
3ce70a2 
Adds a doc section for setting up Ingress on GKE. At the end of the doc, the user will be able to view the Ray dashboard UI via the Ingress.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
@architkulkarni architkulkarni added release-blocker P0 Issue that blocks the release v2.7.0-pick labels Aug 29, 2023
@GeneDer
Copy link
Contributor

GeneDer commented Aug 29, 2023

Pick of #38935

zhe-thoughts
zhe-thoughts approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean docs change

@GeneDer GeneDer merged commit 384e201 into ray-project:releases/2.7.0 Aug 29, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer GeneDer approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome wuisawesome is a code owner

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman DmitriGekhtman is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@kevin85421 kevin85421 Awaiting requested review from kevin85421 kevin85421 is a code owner

Assignees

@GeneDer GeneDer

@zhe-thoughts zhe-thoughts

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@architkulkarni @GeneDer @zhe-thoughts