Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Backwards compatibility for Preprocessor that have been fit in older versions #39173

Merged
merged 6 commits into from
Sep 9, 2023

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Aug 31, 2023

Per user ask, support transforming with Preprocessors that have been fit in an older version of Ray.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/ray/data/preprocessor.py Show resolved Hide resolved
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam amogkam merged commit 6ea6d5d into ray-project:master Sep 9, 2023
41 of 49 checks passed
@amogkam amogkam deleted the preprocessor-backwards-compat branch September 9, 2023 01:01
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
…in older versions (ray-project#39173)

Per user ask, support transforming with Preprocessors that have been fit in an older version of Ray.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…in older versions (ray-project#39173)

Per user ask, support transforming with Preprocessors that have been fit in an older version of Ray.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants