Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Backwards compatibility for Preprocessor that have been fit in older versions #39488

Merged

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Sep 8, 2023

This is a cherry pick of #39173

Per user ask, support transforming with Preprocessors that have been fit in an older version of Ray.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a concrete user ask; qualifies for picking

@amogkam amogkam added release-blocker P0 Issue that blocks the release P0 Issues that should be fixed in short order labels Sep 8, 2023
@GeneDer
Copy link
Contributor

GeneDer commented Sep 8, 2023

@amogkam Can you get #39173 merged into master first?

@GeneDer
Copy link
Contributor

GeneDer commented Sep 8, 2023

Also, how risky is this change without a unit test?

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam
Copy link
Contributor Author

amogkam commented Sep 8, 2023

yes will get #39173 merged once CI finishes

@amogkam
Copy link
Contributor Author

amogkam commented Sep 9, 2023

Original is merged @GeneDer

@GeneDer GeneDer merged commit b77e776 into ray-project:releases/2.7.0 Sep 9, 2023
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Issues that should be fixed in short order release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants