[train][release] Fix tune_worker_fault_tolerance release test node killing
#39233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
approved these changes
Sep 2, 2023
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
pushed a commit
to matthewdeng/ray
that referenced
this pull request
Sep 9, 2023
…killing (ray-project#39233) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
GeneDer
pushed a commit
that referenced
this pull request
Sep 10, 2023
…39515) * [docs] update doc links in Use Cases (#39445) Signed-off-by: Matthew Deng <matt@anyscale.com> * [train][release] Fix `tune_worker_fault_tolerance` release test node killing (#39233) Signed-off-by: Justin Yu <justinvyu@anyscale.com> * [train] Do not raise warning when no results were reported (#39454) Signed-off-by: Kai Fricke <kai@anyscale.com> * [train] add diagram in overview page (#39512) Signed-off-by: Matthew Deng <matt@anyscale.com> * [train] New persistence mode: Sanity-check release test (#39354) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> * [train][doc] Configuring persistent storage user guide (#39428) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: matthewdeng <matthew.j.deng@gmail.com> Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Co-authored-by: matthewdeng <matt@anyscale.com> * [train][doc] New checkpointing user guide (#39505) Signed-off-by: Justin Yu <justinvyu@anyscale.com> --------- Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: matthewdeng <matthew.j.deng@gmail.com> Co-authored-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…killing (ray-project#39233) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…killing (ray-project#39233) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
AWS has changed the API for a node to query its own metadata. Previously, this test was passing trivially with no node termination. This PR makes the test fail if no node termination attempts succeeded.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.