[train] New persistence mode: Add storage type telemetry #39286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…age_telemetry Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
reviewed
Sep 6, 2023
| - 'custom' = All other storage schemes, which includes ALL cases where a | ||
| custom `storage_filesystem` is provided. | ||
| """ | ||
| whitelist = {"local", "mock", "s3", "gcs", "abfs", "hdfs"} |
There was a problem hiding this comment.
Is there also gs as an alternative for gcs?
There was a problem hiding this comment.
Nope, pyarrow fs type name is always gcs
Comment on lines
+955
to
+957
| if _use_storage_context(): | ||
| air_usage.tag_storage_type(experiments[0].storage) | ||
|
|
There was a problem hiding this comment.
How come this is tracked down here rather than where the TODO was?
There was a problem hiding this comment.
I need the Experiment object to be initialized to access the StorageContext
matthewdeng
approved these changes
Sep 6, 2023
jonathan-anyscale
pushed a commit
to jonathan-anyscale/ray
that referenced
this pull request
Sep 6, 2023
…#39286) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
pushed a commit
to matthewdeng/ray
that referenced
this pull request
Sep 7, 2023
…#39286) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
GeneDer
pushed a commit
that referenced
this pull request
Sep 7, 2023
…39368) * fix tune_hvd_keras (#39223) Signed-off-by: Justin Yu <justinvyu@anyscale.com> * [train] New persistence mode: Add backwards compatibility support for `local_dir` (#39282) Signed-off-by: Justin Yu <justinvyu@anyscale.com> * [train] Add TrainContext.get_storage (#39281) Signed-off-by: Justin Yu <justinvyu@anyscale.com> * [train] New persistence mode: Deprecate experimental distributed checkpointing configs (#39279) Signed-off-by: Justin Yu <justinvyu@anyscale.com> * [Release] Fix `air_example_dolly_v2_lightning_fsdp_finetuning` with large cpu mem head node (#39263) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> * Remove all "ray.init" cell output in the example notebooks. (#39283) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> * [train] New persistence mode: Add storage type telemetry (#39286) Signed-off-by: Justin Yu <justinvyu@anyscale.com> * [air-doc] Rework experiment tracking docs for Torch trainer. (#38684) * Rework experiment tracking for DDP trainer. Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * [docs] add Developer Guides landing page (#39296) Signed-off-by: Matthew Deng <matt@anyscale.com> * [2.7][Doc] Clean up more Ray Train examples (#39284) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> * disable Train examples with authentication for now. (#39358) Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * [air] move doc_code and examples into respective libraries (#39298) Signed-off-by: Matthew Deng <matt@anyscale.com> --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> Signed-off-by: Matthew Deng <matt@anyscale.com> Co-authored-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: Yunxuan Xiao <yunxuanx@anyscale.com> Co-authored-by: xwjiang2010 <87673679+xwjiang2010@users.noreply.github.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
…#39286) Signed-off-by: Justin Yu <justinvyu@anyscale.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…#39286) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…#39286) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This adds back storage telemetry for the new codepath. Only a whitelist of default pyarrow implementations will be tracked. All custom filesystems will be marked as "custom".
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.