-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[train] New persistence mode: Add storage type telemetry #39286
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
41ebb19
add simplified telemetry for storage type in new codepath
justinvyu 4e1a6df
Merge branch 'master' of https://github.com/ray-project/ray into stor…
justinvyu 092d03f
skip gcs test
justinvyu 7f72a5a
Merge branch 'master' of https://github.com/ray-project/ray into stor…
justinvyu 4c18808
Merge branch 'master' of https://github.com/ray-project/ray into stor…
justinvyu 3f40200
add other
justinvyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -677,7 +677,6 @@ class and registered trainables. | |
if _use_storage_context(): | ||
local_path, remote_path = None, None | ||
sync_config = sync_config or SyncConfig() | ||
# TODO(justinvyu): Fix telemetry for the new persistence. | ||
|
||
# TODO(justinvyu): Finalize the local_dir vs. env var API in 2.8. | ||
# For now, keep accepting both options. | ||
|
@@ -953,6 +952,9 @@ class and registered trainables. | |
|
||
progress_metrics = _detect_progress_metrics(_get_trainable(run_or_experiment)) | ||
|
||
if _use_storage_context(): | ||
air_usage.tag_storage_type(experiments[0].storage) | ||
|
||
Comment on lines
+955
to
+957
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How come this is tracked down here rather than where the TODO was? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need the |
||
# NOTE: Report callback telemetry before populating the list with default callbacks. | ||
# This tracks user-specified callback usage. | ||
air_usage.tag_callbacks(callbacks) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there also
gs
as an alternative forgcs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, pyarrow fs type name is always gcs