Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Cleanup all LightningTrainer Mentions in Ray Doc #39406

Merged

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Sep 7, 2023

Why are these changes needed?

  • Refractor Use PyTorch Lightning with Tune.
  • Removed some Ray AIR / Ray LightningTrainer mentions in our doc
  • Add ref links to our new getting start page.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


via NFL on GIPHY

@matthewdeng matthewdeng merged commit 41cb273 into ray-project:master Sep 8, 2023
20 checks passed
matthewdeng pushed a commit to matthewdeng/ray that referenced this pull request Sep 8, 2023
…9406)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
GeneDer pushed a commit that referenced this pull request Sep 8, 2023
…39468)

* [train] Fix issues in migration of tune_cifar_torch_pbt_example (#39158)

Resolves three issues that come up when migrating the `tune_cifar_torch_pbt_example` from Ray 2.6 to Ray 2.7:

1. There is a warning message because PBT uses the `_schedule_trial_save` interface. This is added to the white list attributes so it doesn't come up anymore.
2. PBT malfunctions in Python 2.7, so instead of silently failing, we raise an error and ask users to migrate
3. When users use old `ray.air.Checkpoint` APIs on `ray.train.Checkpoint`, we should raise an actionable error message.

Signed-off-by: Kai Fricke <kai@anyscale.com>

* [tune] Make Trainable.save/restore developer APIs (#39391)

Signed-off-by: Kai Fricke <kai@anyscale.com>

* [Telemetry] Add Telemetry for Ray Train Utilities (#39363)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>

* [train] update Train API references & annotations (#39294)

Signed-off-by: Matthew Deng <matt@anyscale.com>

* [2.7] Cleanup all LightningTrainer Mentions in Ray Doc (#39406)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>

* [train] remove _max_cpu_fraction_per_node (#39412)

Signed-off-by: Matthew Deng <matt@anyscale.com>

* [train] Legacy interface cleanup (`air.Checkpoint`, `LegacyExperimentAnalysis`) (#39289)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Co-authored-by: matthewdeng <matt@anyscale.com>

* [Train][Telemetry] Limit the usage of `ray.train.torch.get_device`. (#39432)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>

* [train-ci] Fix Train examples with authentication buildkite commands. (#39387)

* [train-ci] fix Train examples with authentication buildkite commands.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

* [train][doc] Remove preprocessor reference in tune+train user guide (#39442)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [train/docs] Extend resource guide (training backend + choosing resources) (#39202)

Signed-off-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>

* fix docs

Signed-off-by: Matthew Deng <matt@anyscale.com>

* [Minor] Remove remaining LightningTrainer Mentions (#39441)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>

---------

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
Co-authored-by: Yunxuan Xiao <yunxuanx@anyscale.com>
Co-authored-by: Justin Yu <justinvyu@anyscale.com>
Co-authored-by: xwjiang2010 <87673679+xwjiang2010@users.noreply.github.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
…9406)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…9406)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants