[Train][Telemetry] Limit the usage of ray.train.torch.get_device.
#39432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdeng
approved these changes
Sep 8, 2023
kouroshHakha
approved these changes
Sep 8, 2023
matthewdeng
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
krfricke
as code owners
matthewdeng
pushed a commit
to matthewdeng/ray
that referenced
this pull request
Sep 8, 2023
…ay-project#39432) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
GeneDer
pushed a commit
that referenced
this pull request
Sep 8, 2023
…39468) * [train] Fix issues in migration of tune_cifar_torch_pbt_example (#39158) Resolves three issues that come up when migrating the `tune_cifar_torch_pbt_example` from Ray 2.6 to Ray 2.7: 1. There is a warning message because PBT uses the `_schedule_trial_save` interface. This is added to the white list attributes so it doesn't come up anymore. 2. PBT malfunctions in Python 2.7, so instead of silently failing, we raise an error and ask users to migrate 3. When users use old `ray.air.Checkpoint` APIs on `ray.train.Checkpoint`, we should raise an actionable error message. Signed-off-by: Kai Fricke <kai@anyscale.com> * [tune] Make Trainable.save/restore developer APIs (#39391) Signed-off-by: Kai Fricke <kai@anyscale.com> * [Telemetry] Add Telemetry for Ray Train Utilities (#39363) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> * [train] update Train API references & annotations (#39294) Signed-off-by: Matthew Deng <matt@anyscale.com> * [2.7] Cleanup all LightningTrainer Mentions in Ray Doc (#39406) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> * [train] remove _max_cpu_fraction_per_node (#39412) Signed-off-by: Matthew Deng <matt@anyscale.com> * [train] Legacy interface cleanup (`air.Checkpoint`, `LegacyExperimentAnalysis`) (#39289) Signed-off-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> * [Train][Telemetry] Limit the usage of `ray.train.torch.get_device`. (#39432) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> * [train-ci] Fix Train examples with authentication buildkite commands. (#39387) * [train-ci] fix Train examples with authentication buildkite commands. Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * [train][doc] Remove preprocessor reference in tune+train user guide (#39442) Signed-off-by: Justin Yu <justinvyu@anyscale.com> * [train/docs] Extend resource guide (training backend + choosing resources) (#39202) Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> * fix docs Signed-off-by: Matthew Deng <matt@anyscale.com> * [Minor] Remove remaining LightningTrainer Mentions (#39441) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> --------- Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com> Co-authored-by: Yunxuan Xiao <yunxuanx@anyscale.com> Co-authored-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: xwjiang2010 <87673679+xwjiang2010@users.noreply.github.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…ay-project#39432) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ay-project#39432) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In Ray 2.7, we added a series of TagKey for TorchTrainer utilities. We are using
ray.train.torch.get_devicein multiple places internally. To avoid report inaccurate telemetry metrics, we want to expose this API only for user code.This PR limits the usage of this API, and converted all internal calls with
ray.air._internal.torch_utils.get_device.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.