Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] loosen the check on release object #39570

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[core] loosen the check on release object #39570

merged 2 commits into from
Sep 12, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Sep 12, 2023

This check is probably too strict, as the same client might call release object multiple times. This is a benign behavior and we shouldn't crash.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 added the release-blocker P0 Issue that blocks the release label Sep 12, 2023
@scv119 scv119 linked an issue Sep 12, 2023 that may be closed by this pull request
[Core] Check failed: RemoveFromClientObjectIds(object_id, client) == 1 #39478
Closed
rkooo567
rkooo567 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed existing check is too strong.

@scv119 is it possible to update relevant docstring? For example, we should call out Release APIs are idempotent from now?

@scv119 scv119 merged commit 6cc3cda into ray-project:master Sep 12, 2023
101 of 108 checks passed
scv119 added a commit to scv119/ray that referenced this pull request Sep 12, 2023
@scv119
[core] loosen the check on release object (ray-project#39570)
d7ae0d8 
This check is probably too strict, as the same client might call release object multiple times. This is a benign behavior and we shouldn't crash.
GeneDer pushed a commit that referenced this pull request Sep 12, 2023
@scv119
[core] loosen the check on release object (#39570) (#39577)
dbc8c52 
This check is probably too strict, as the same client might call release object multiple times. This is a benign behavior and we shouldn't crash.
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 12, 2023
@scv119 @simonsays1980
[core] loosen the check on release object (ray-project#39570)
c9304b9 
This check is probably too strict, as the same client might call release object multiple times. This is a benign behavior and we shouldn't crash.
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@scv119
[core] loosen the check on release object (ray-project#39570)
d956861 
This check is probably too strict, as the same client might call release object multiple times. This is a benign behavior and we shouldn't crash.

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@rkooo567 rkooo567

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Check failed: RemoveFromClientObjectIds(object_id, client) == 1
2 participants
@scv119 @rkooo567