Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] loosen the check on release object (#39570) #39577

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[core] loosen the check on release object (#39570) #39577

merged 1 commit into from
Sep 12, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Sep 12, 2023 •
edited
Loading

This check is probably too strict, as the same client might call release object multiple times. This is a benign behavior and we shouldn't crash.

Cherry-pick to fix user issues.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119
[core] loosen the check on release object (ray-project#39570)
d7ae0d8 
This check is probably too strict, as the same client might call release object multiple times. This is a benign behavior and we shouldn't crash.
@scv119 scv119 linked an issue Sep 12, 2023 that may be closed by this pull request
[Core] Check failed: RemoveFromClientObjectIds(object_id, client) == 1 #39478
Closed
rkooo567
rkooo567 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should we ask the user to try before cherry pick?

zhe-thoughts
zhe-thoughts approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release blocker; let's pick

@GeneDer GeneDer self-assigned this Sep 12, 2023
@GeneDer
Copy link
Contributor

GeneDer commented Sep 12, 2023

@scv119 to fix DCO

@GeneDer GeneDer merged commit dbc8c52 into ray-project:releases/2.7.0 Sep 12, 2023
107 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@GeneDer GeneDer

@zhe-thoughts zhe-thoughts

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Check failed: RemoveFromClientObjectIds(object_id, client) == 1
4 participants
@scv119 @GeneDer @zhe-thoughts @rkooo567