Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] Deprecate LightningTrainer #40163

Merged

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Oct 5, 2023

Why are these changes needed?

Deprecate LightningTrainer, uses should use TorchTrainer only in Ray 2.8.

We keep the code but immediately raise an Error when the users initialize a LightningTrainer, LightningCheckpoint, LightningPredictor. In 2.9, we will completely remove the code.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya marked this pull request as ready for review October 5, 2023 23:54
@woshiyyya woshiyyya requested a review from a team as a code owner October 6, 2023 00:04
@woshiyyya woshiyyya force-pushed the train/deprecate_lightning_trainer branch from 61f211e to 3503d59 Compare October 6, 2023 00:05
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this needs ci team to review.

@woshiyyya
Copy link
Member Author

@aslonnie Seems that using git push -f will automatically tag ray-project/ray-ci for review?

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@aslonnie
Copy link
Collaborator

aslonnie commented Oct 6, 2023

Seems that using git push -f will automatically tag ray-project/ray-ci for review?

that should not be the case.. no idea..

you can try if you can reproduce it.

it is more likely that there was a messy rebase or something.

woshiyyya and others added 3 commits October 9, 2023 23:06
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Yunxuan Xiao <yunxuanx@anyscale.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 11, 2023
@matthewdeng matthewdeng merged commit 7470eb2 into ray-project:master Oct 11, 2023
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants