-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train] Deprecate LightningTrainer #40163
[Train] Deprecate LightningTrainer #40163
Conversation
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
61f211e
to
3503d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this needs ci team to review.
@aslonnie Seems that using |
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
that should not be the case.. no idea.. you can try if you can reproduce it. it is more likely that there was a messy rebase or something. |
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Yunxuan Xiao <yunxuanx@anyscale.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Why are these changes needed?
Deprecate LightningTrainer, uses should use TorchTrainer only in Ray 2.8.
We keep the code but immediately raise an Error when the users initialize a LightningTrainer, LightningCheckpoint, LightningPredictor. In 2.9, we will completely remove the code.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.