Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] Fix lightning 2.0 import path #40266

Merged

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Oct 11, 2023

Why are these changes needed?

Previously we decide the import path for some components by the lightning/pytorch_lightning version. While if the users installed pytorch_lightning=2.x.x, they will not be able to use the new import path lightning.pytorch, which caused inconsistency issue.

Now we always import from lightning.pytorch first, then fallback to pytorch_lightning.

Related issue number

Closes #40260 #40261

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya
Copy link
Member Author

woshiyyya commented Oct 11, 2023

Tests passed: https://buildkite.com/ray-project/release-tests-pr/builds/55457#_

But still, we already deleted these release tests in #40163

woshiyyya and others added 2 commits October 13, 2023 14:18
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 16, 2023
@matthewdeng matthewdeng merged commit c6baff2 into ray-project:master Oct 17, 2023
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release test lightning_gpu_train_3x16_3x1.aws failed
2 participants