Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API cleanups. Remove worker argument. Remove some deprecated arguments. #4025

Merged
merged 3 commits into from
Feb 15, 2019
Merged

API cleanups. Remove worker argument. Remove some deprecated arguments. #4025

merged 3 commits into from
Feb 15, 2019

Conversation

robertnishihara
Copy link
Collaborator

@robertnishihara robertnishihara commented Feb 12, 2019 •
edited
Loading

This PR does the following:

  • Removes driver_mode and use_raylet arguments to ray.init().
  • Deprecates redirect_ouput and redirect_worker_output arguments to ray.init().
  • Removes _submit.
  • Removes worker argument from Ray API methods.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11835/
Test FAILed.

ericl
ericl approved these changes Feb 13, 2019
View reviewed changes
python/ray/parameter.py Outdated
raise ValueError(
"The 'num_workers' argument is deprecated. Please use "
"'num_cpus' instead.")
"The 'redirect_worker_output' argument is deprecated. Please "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: raise DeprecationWarning here and elsewhere

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11958/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11955/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11965/
Test PASSed.

@robertnishihara robertnishihara mentioned this pull request Feb 15, 2019
Closed
suquark
suquark reviewed Feb 15, 2019
View reviewed changes
python/ray/node.py
@@ -262,7 +262,7 @@ def start_redis(self):
redis_shard_ports=self._ray_params.redis_shard_ports,
num_redis_shards=self._ray_params.num_redis_shards,
redis_max_clients=self._ray_params.redis_max_clients,
redirect_worker_output=self._ray_params.redirect_worker_output,
redirect_worker_output=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just remove "redirect_worker_output" of _make_inc_temp?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suquark I think that's probably a good idea, but the reason I didn't do it here is that I thought we might still need that functionality if starting workers in tmux.

@pcmoritz pcmoritz merged commit 5f71751 into ray-project:master Feb 15, 2019
@robertnishihara robertnishihara deleted the apicleanups branch February 15, 2019 18:58
@pcmoritz pcmoritz mentioned this pull request Feb 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suquark suquark suquark left review comments

@ericl ericl ericl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertnishihara @AmplabJenkins @ericl @suquark @pcmoritz