Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Cherry-pick #41634 #41665

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[Data] Cherry-pick #41634 #41665

merged 1 commit into from
Dec 7, 2023

Conversation

scottjlee
Copy link
Contributor

Why are these changes needed?

Related issue number

Cherry pick #41634

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scottjlee
[Data] Skip test_client_compat.py::test_client_data_get unit test (r…
3fe84c9 
…ay-project#41634)

ray-project#41466 enables Ray Data streaming executor by default for all datasets. As a result, the Ray Data execution in `test_client_data_get` test is now executed through the streaming executor, which is known to have many incompatibilities since Ray 2.7. So, we skip the test which checks compatibility between Ray Client and Ray Data, until we have a future Ray Client implementation which can better support Ray Data usage.

Signed-off-by: Scott Lee <sjl@anyscale.com>
@scottjlee scottjlee changed the base branch from master to releases/2.9.0 December 6, 2023 18:12
@architkulkarni architkulkarni added release-blocker P0 Issue that blocks the release v2.9.0-pick labels Dec 6, 2023
@scottjlee scottjlee marked this pull request as ready for review December 6, 2023 18:17
@architkulkarni architkulkarni merged commit c5dc784 into ray-project:releases/2.9.0 Dec 7, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@architkulkarni architkulkarni architkulkarni approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

Assignees

@architkulkarni architkulkarni

@zhe-thoughts zhe-thoughts

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottjlee @c21 @architkulkarni @zhe-thoughts