Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 41370: Tune update_config should use config.to_dict() if config is an _Config. #42116

Merged
merged 10 commits into from
Jan 24, 2024
Merged

[RLlib] Issue 41370: Tune update_config should use config.to_dict() if config is an _Config. #42116

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
10fb70e
Fixed the problem with 'AlgorithmConfig' objects in the 'JsonLoggerCa…
simonsays1980 Dec 28, 2023
04d7388
LINTER
simonsays1980 Dec 28, 2023
77ef485
Merge branch 'master' into fix-issue-41370-config-to-dict
simonsays1980 Jan 4, 2024
5afddbe
Changed checking for 'dict' to checking for 'AlgorithmConfig'.
simonsays1980 Jan 4, 2024
9c6f31e
Merge branch 'master' into fix-issue-41370-config-to-dict
simonsays1980 Jan 11, 2024
26ec434
Moved import of 'AlgorithmConfig' into function, due to circular impo…
simonsays1980 Jan 24, 2024
d21ac80
LINTER.
simonsays1980 Jan 24, 2024
8916a46
Merge branch 'master' into fix-issue-41370-config-to-dict
simonsays1980 Jan 24, 2024
2d9e3f5
Apply suggestions from code review
sven1977 Jan 24, 2024
20a25fe
Apply suggestions from code review
sven1977 Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/ray/tune/logger/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def close(self):
self.local_out.close()

def update_config(self, config: Dict):
self.config = config
self.config = config if isinstance(config, dict) else config.to_dict()
simonsays1980 marked this conversation as resolved.
Show resolved Hide resolved
config_out = os.path.join(self.logdir, EXPR_PARAM_FILE)
with open(config_out, "w") as f:
json.dump(self.config, f, indent=2, sort_keys=True, cls=SafeFallbackEncoder)
Expand Down Expand Up @@ -115,7 +115,9 @@ def log_trial_end(self, trial: "Trial", failed: bool = False):
del self._trial_files[trial]

def update_config(self, trial: "Trial", config: Dict):
self._trial_configs[trial] = config
self._trial_configs[trial] = (
simonsays1980 marked this conversation as resolved.
Show resolved Hide resolved
config if isinstance(config, dict) else config.to_dict()
)

config_out = os.path.join(trial.local_path, EXPR_PARAM_FILE)
with open(config_out, "w") as f:
Expand Down