New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Issue 41370: Tune update_config
should use config.to_dict() if config is an _Config
.
#42116
Merged
sven1977
merged 10 commits into
ray-project:master
from
simonsays1980:fix-issue-41370-config-to-dict
Jan 24, 2024
Merged
[RLlib] Issue 41370: Tune update_config
should use config.to_dict() if config is an _Config
.
#42116
sven1977
merged 10 commits into
ray-project:master
from
simonsays1980:fix-issue-41370-config-to-dict
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llback' and 'JsonLogger' classes. Due to the fact that the 'AlgorithmConfig' is not a dictionary the 'params.json' file contained simply a object reference and not the dict. This commit fixes this issue. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
sven1977
reviewed
Jan 4, 2024
sven1977
reviewed
Jan 4, 2024
sven1977
changed the title
Fix issue 41370 config to dict
[RLlib] Issue 41370: Tune Jan 4, 2024
update_config
should use config.to_dict() if config is an AlgorithmConfig
.
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…rts i. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
sven1977
reviewed
Jan 24, 2024
sven1977
reviewed
Jan 24, 2024
sven1977
reviewed
Jan 24, 2024
Signed-off-by: Sven Mika <sven@anyscale.io>
sven1977
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
sven1977
reviewed
Jan 24, 2024
Signed-off-by: Sven Mika <sven@anyscale.io>
sven1977
changed the title
[RLlib] Issue 41370: Tune
[RLlib] Issue 41370: Tune Jan 24, 2024
update_config
should use config.to_dict() if config is an AlgorithmConfig
.update_config
should use config.to_dict() if config is an _Config
.
khluu
pushed a commit
to khluu/ray
that referenced
this pull request
Jan 24, 2024
… if config is an `_Config`. (ray-project#42116) Signed-off-by: khluu <khluu000@gmail.com>
khluu
pushed a commit
to khluu/ray
that referenced
this pull request
Jan 24, 2024
… if config is an `_Config`. (ray-project#42116) Signed-off-by: khluu <khluu000@gmail.com>
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When storing the
params.json
forRLlib
experiments theconfig
is of classAlgorithmConfig
and notdict
. Because of this theparams.json
contained only an object description, but not the content. This PR fixes this by calling theto_dict()
-method of theAlgorithmConfig
.Other config classes can also implement a
to_dict
method such that this solution is well generalizable.Everything that is
dict
remainsdict
.Related issue number
Closes #41370
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.