[core][gcs] Fix task events profile events per task leak #42248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a follow-up, I think we should add explicit memory consumption regression metrics to GCS and other components for our long running tests. #42250 |
rkooo567
approved these changes
Jan 9, 2024
| if (existing_task.profile_events().events_size() > max_num_profile_events_per_task) { | ||
| auto to_drop = | ||
| existing_task.profile_events().events_size() - max_num_profile_events_per_task; | ||
| existing_task.mutable_profile_events()->mutable_events()->DeleteSubrange(0, to_drop); |
There was a problem hiding this comment.
if to_drop is negative, it will be noop?
There was a problem hiding this comment.
it will not enter the if clause in this case.
rickyyx
added a commit
to rickyyx/ray
that referenced
this pull request
Jan 9, 2024
…#42248) --------- Signed-off-by: rickyyx <rickyx@anyscale.com>
can-anyscale
pushed a commit
that referenced
this pull request
Jan 9, 2024
…2268) When a long running task keeps submitting tasks (e.g. driver task, actor task), it generates many profile events as part of task submission. While we already cap the number of profile events in a task at the core worker (where task events are produced and reported), we are not doing that on GCS (the sink), so it's possible when new task events merged to existing ones, it goes unbounded. Signed-off-by: rickyyx <rickyx@anyscale.com>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…#42248) --------- Signed-off-by: rickyyx <rickyx@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When a long running task keeps submitting tasks (e.g. driver task, actor task), it generates many profile events as part of task submission.
While we already cap the number of profile events in a task at the core worker (where task events are produced and reported), we are not doing that on GCS (the sink), so it's possible when new task events merged to existing ones, it goes unbounded.
Closes #42144
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.