Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][gcs] Fix task events profile events per task leak (#42248) #42268

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jan 9, 2024


Why are these changes needed?

When a long running task keeps submitting tasks (e.g. driver task, actor task), it generates many profile events as part of task submission.

While we already cap the number of profile events in a task at the core worker (where task events are produced and reported), we are not doing that on GCS (the sink), so it's possible when new task events merged to existing ones, it goes unbounded.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…#42248)

---------

Signed-off-by: rickyyx <rickyx@anyscale.com>
@architkulkarni architkulkarni added release-blocker P0 Issue that blocks the release v2.9.1-pick labels Jan 9, 2024
@architkulkarni architkulkarni self-assigned this Jan 9, 2024
@rickyyx rickyyx marked this pull request as ready for review January 9, 2024 18:00
@rickyyx rickyyx requested a review from a team as a code owner January 9, 2024 18:00
@can-anyscale can-anyscale merged commit b2d50b8 into ray-project:releases/2.9.1 Jan 9, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants