[train] remove DEFAULT_NCCL_SOCKET_IFNAME #42808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: matthewdeng <matt@anyscale.com>
woshiyyya
approved these changes
Jan 31, 2024
matthewdeng
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
Yard1,
maxpumperla,
justinvyu and
a team
as code owners
woshiyyya
requested changes
Feb 2, 2024
woshiyyya
approved these changes
Feb 2, 2024
|
Looks good! Thanks for the cleanup. Let's merge it. |
tterrysun
pushed a commit
to tterrysun/ray
that referenced
this pull request
Feb 14, 2024
Signed-off-by: matthewdeng <matt@anyscale.com> Signed-off-by: tterrysun <terry@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This was originally added in #28633, #31824 in an attempt to set sensible default configurations. After further investigating, it appears that users actually expect (and prefer) the default unset values.
This PR also removes additional configs set in release tests, as the test environments have already been configured properly.
Related issue number
Closes #42652
Closes #32519
Checks
Release Tests (See AWS tests): https://buildkite.com/ray-project/release/builds/7192
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.