-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train] Automatically set NCCL_SOCKET_IFNAME
to use ethernet
#28633
[Train] Automatically set NCCL_SOCKET_IFNAME
to use ethernet
#28633
Conversation
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for doing this!!
2. Choose the network interface that corresponds to the private IP address of your node. In most cases, this will be either | ||
`ens3` or `ens5`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any NCCL documentation that corroborates this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no...nothing I could find. This is just from our experiences. Unfortunately the documentation around this is pretty sparse :(
# Use ethernet when possible. | ||
# NCCL_SOCKET_IFNAME does a prefix match so "ens3" or "ens5" will match with | ||
# "en". | ||
DEFAULT_NCCL_SOCKET_IFNAME = "en,eth,bond" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking my understanding, does order matter here? Or does it matter what the order of ifconfig
outputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first is prefered (first anything starting in en, then eth, then bond)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do we have passing release tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, should we log or warn when we are doing this?
Looks great ! Even updated tests are release tests with pytorch, can you also kick them off on PR to ensure everything works as expected ? |
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
@Yard1 added a debug statement |
Passing release test here: https://buildkite.com/ray-project/release-tests-pr/builds/15918#01835d56-ea64-4d75-8bac-56fc4d1c0198 |
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
Torch comparison benchmark release test passing here: https://buildkite.com/ray-project/release-tests-pr/builds/15987#018361b3-f423-4f53-bfbf-ed73cf7a7f8d |
Signed-off-by: Amog Kamsetty amogkamsetty@yahoo.com
Automatically set
NCCL_SOCKET_IFNAME
to prefer ethernet. Also adds a FAQ section in the docs on how to diagnose this issue.Closes #26663
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.