Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train+tune] Make some deprecations for 2.10 #42812

Merged
merged 12 commits into from
Jan 31, 2024
Merged

[train+tune] Make some deprecations for 2.10 #42812

merged 12 commits into from
Jan 31, 2024

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

This PR hard-deprecates/removes APIs that were scheduled for removal: TuneConfig(chdir_to_trial_dir) and certain SyncConfig parameters. This PR also resolves some other miscellaneous TODOs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@justinvyu
hard deprecate chdir_to_trial_dir
f517ae0 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
hard deprecate sync config params
421a582 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
hard deprecate old sync config import path + remove hard-deprecated p…
4beb648 
…ublic syncer

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
mark syncer interface as developer api
974be7e 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
tune_sklearn has been deleted
3660e60 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
circular dep has been fixed
28791fa 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
remove experiment analysis hard-deprecated methods
31a16b8 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
experiment/trial property hard deprecations
db6185f 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
fix lint
1771a98 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu
mark all the things to delete in 2.11
4f6bb07 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
matthewdeng approved these changes Jan 30, 2024
View reviewed changes
python/ray/tune/experiment/experiment.py Outdated Show resolved Hide resolved
python/ray/tune/experiment/trial.py Outdated Show resolved Hide resolved
python/ray/tune/experiment/trial.py Outdated Show resolved Hide resolved
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into make…
78de887 
…_some_deprecations
@justinvyu
address comments
adc0d7d 
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu merged commit 3e59df1 into ray-project:master Jan 31, 2024
9 checks passed
@justinvyu justinvyu deleted the make_some_deprecations branch January 31, 2024 22:27
justinvyu added a commit that referenced this pull request Feb 1, 2024
@justinvyu
Revert "[train+tune] Make some deprecations for 2.10 (#42812)"
1bded6f 
This reverts commit 3e59df1.
@justinvyu justinvyu mentioned this pull request Feb 1, 2024
Merged
justinvyu added a commit that referenced this pull request Feb 1, 2024
@justinvyu
Revert "[train+tune] Make some deprecations for 2.10 (#42812)" (#42899)
9fd7a7f 
This reverts commit 3e59df1.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu mentioned this pull request Feb 1, 2024
Merged
8 tasks
shrekris-anyscale pushed a commit to shrekris-anyscale/ray that referenced this pull request Feb 1, 2024
@justinvyu @shrekris-anyscale
[train+tune] Make some deprecations for 2.10 (ray-project#42812)
fc272d6 
This PR hard-deprecates/removes APIs that were scheduled for removal: `TuneConfig(chdir_to_trial_dir)` and certain `SyncConfig` parameters. This PR also resolves some other miscellaneous TODOs.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinvyu added a commit that referenced this pull request Feb 5, 2024
@justinvyu
Revert "Revert "[train+tune] Make some deprecations for 2.10" (#42899)…
0dff97e 
…" (#42909)

This PR hard-deprecates/removes APIs that were scheduled for removal: `TuneConfig(chdir_to_trial_dir)` and certain `SyncConfig` parameters. This PR also resolves some other miscellaneous TODOs.

This PR fixes some RLlib tests that were failing previously from #42812

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
tterrysun pushed a commit to tterrysun/ray that referenced this pull request Feb 14, 2024
@justinvyu @tterrysun
[train+tune] Make some deprecations for 2.10 (ray-project#42812)
cd4a739 
This PR hard-deprecates/removes APIs that were scheduled for removal: `TuneConfig(chdir_to_trial_dir)` and certain `SyncConfig` parameters. This PR also resolves some other miscellaneous TODOs.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: tterrysun <terry@anyscale.com>
tterrysun pushed a commit to tterrysun/ray that referenced this pull request Feb 14, 2024
@justinvyu @tterrysun
Revert "[train+tune] Make some deprecations for 2.10 (ray-project#42812…
b11f5df 
…)" (ray-project#42899)

This reverts commit 3e59df1.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: tterrysun <terry@anyscale.com>
tterrysun pushed a commit to tterrysun/ray that referenced this pull request Feb 14, 2024
@justinvyu @tterrysun
Revert "Revert "[train+tune] Make some deprecations for 2.10" (ray-pr…
5e4dfd0 
…oject#42899)" (ray-project#42909)

This PR hard-deprecates/removes APIs that were scheduled for removal: `TuneConfig(chdir_to_trial_dir)` and certain `SyncConfig` parameters. This PR also resolves some other miscellaneous TODOs.

This PR fixes some RLlib tests that were failing previously from ray-project#42812

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: tterrysun <terry@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@amogkam amogkam Awaiting requested review from amogkam

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees

@matthewdeng matthewdeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinvyu @matthewdeng