Revert "Revert "[train+tune] Make some deprecations for 2.10" (#42899)" #42909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…ublic syncer Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…_some_deprecations
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…_some_deprecations
justinvyu
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla,
woshiyyya,
a team,
sven1977,
avnishn,
ArturNiederfahrenhorst and
kouroshHakha
as code owners
matthewdeng
approved these changes
Feb 1, 2024
This reverts commit eddce52. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…_some_deprecations
ArturNiederfahrenhorst
approved these changes
Feb 5, 2024
8 tasks
justinvyu
added a commit
that referenced
this pull request
Feb 7, 2024
…urable` release test (#43029) #42909 hard deprecated outdated `SyncConfig` parameters, and this release test was not updated along with the rest of the examples. This `syncer` parameter was already being ignored, so it's okay to remove it fully now. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
tterrysun
pushed a commit
to tterrysun/ray
that referenced
this pull request
Feb 14, 2024
…oject#42899)" (ray-project#42909) This PR hard-deprecates/removes APIs that were scheduled for removal: `TuneConfig(chdir_to_trial_dir)` and certain `SyncConfig` parameters. This PR also resolves some other miscellaneous TODOs. This PR fixes some RLlib tests that were failing previously from ray-project#42812 --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: tterrysun <terry@anyscale.com>
tterrysun
pushed a commit
to tterrysun/ray
that referenced
this pull request
Feb 14, 2024
…urable` release test (ray-project#43029) ray-project#42909 hard deprecated outdated `SyncConfig` parameters, and this release test was not updated along with the rest of the examples. This `syncer` parameter was already being ignored, so it's okay to remove it fully now. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: tterrysun <terry@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR hard-deprecates/removes APIs that were scheduled for removal:
TuneConfig(chdir_to_trial_dir)and certainSyncConfigparameters. This PR also resolves some other miscellaneous TODOs.This PR fixes some RLlib tests that were failing previously from #42812
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.