[tune+rllib] Enforce input type for Experiment(config)
to handle rllib AlgorithmConfig
s
#42816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#42116 resulted in
params.json
saving the wrong data due to dumping anAlgorithmConfig
object rather than a dict, which is the expected type forExperiment.config
.The fix should be to force the user to call
AlgorithmConfig.to_dict
to satisfy the Ray Tune API, rather than adding more rllib specific instance checks in Ray Tune, as is done in this other PR. The_Config
class is a hack that is used in one place, but we should not add more of this class throughout the codebase when possible.The fix to the user post linked below:
Related issue number
#41370
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.