-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Account internal inqueue to previous operator's memory usage #42930
Merged
bveeramani
merged 29 commits into
ray-project:master
from
bveeramani:memory-accounting-inputs
Feb 13, 2024
Merged
[Data] Account internal inqueue to previous operator's memory usage #42930
bveeramani
merged 29 commits into
ray-project:master
from
bveeramani:memory-accounting-inputs
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
9 tasks
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
raulchen
reviewed
Feb 7, 2024
8 tasks
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
raulchen
reviewed
Feb 13, 2024
python/ray/data/_internal/execution/interfaces/op_runtime_metrics.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
raulchen
approved these changes
Feb 13, 2024
python/ray/data/_internal/execution/operators/output_splitter.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
kevin85421
pushed a commit
to kevin85421/ray
that referenced
this pull request
Feb 17, 2024
…ay-project#42930) To make informed scheduling decisions, Ray Data estimates the object store memory usage from each operator. Currently, an operator's inputs count towards its memory usage; however, this can lead to suboptimal scheduling decisions since we primarily care about outputs for backpressuring. This PR updates the implementation so that input counts toward the previous operator's object store usage (i.e., in counts towards the operator that created the data). --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To make informed scheduling decisions, Ray Data estimates the object store memory usage from each operator. Currently, an operator's inputs count towards its memory usage; however, this can lead to suboptimal scheduling decisions since we primarily care about outputs for backpressuring.
This PR updates the implementation so that input counts toward the previous operator's object store usage (i.e., in counts towards the operator that created the data).
Related issue number
Required for #43026
See also #42851 (comment)
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.