[train] Simplify ray.train.xgboost/lightgbm (3/n): Re-implement LightGBMTrainer as a lightweight DataParallelTrainer
#43244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
woshiyyya
approved these changes
Feb 21, 2024
| from ray.train.lightgbm.lightgbm_checkpoint import LightGBMCheckpoint | ||
| from ray.train.lightgbm.lightgbm_predictor import LightGBMPredictor | ||
| from ray.train.lightgbm.lightgbm_trainer import LightGBMTrainer | ||
|
|
||
| __all__ = [ | ||
| "RayTrainReportCallback", | ||
| "LightGBMCheckpoint", | ||
| "LightGBMConfig", |
There was a problem hiding this comment.
nit: Are we exposing this LightGBMConfig as a public API? Seems no special logics in this config, but it's still an argument in the LightGBMTrainer.
There was a problem hiding this comment.
Hmm, yeah there's not really a reason for a user to know about LightGBMConfig.
I was trying to keep the API consistent for LightGBMTrainer with all the other DataParallelTrainers that take in a backend config. So, LightGBMConfig would need to be public for it to be a constructor argument of v2.LightGBMTrainer.
Let me remove it from the public ray.train.lightgbm namespace for now while v2.LightGBMTrainer is still private.
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR re-implements
LightGBMTraineras aDataParallelTrainerthat does not uselightgbm_rayunder the hood, in an effort to unify the trainer implementations and remove that external dependency.This PR is the
lightgbmcounterpart to #42767. See that PR's description for details.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.