-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[train] Simplify ray.train.xgboost/lightgbm
(5/n): Remove xgboost_ray
and lightgbm_ray
dependencies (for release tests)
#43425
[train] Simplify ray.train.xgboost/lightgbm
(5/n): Remove xgboost_ray
and lightgbm_ray
dependencies (for release tests)
#43425
Conversation
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
There are some lint errors but otherwise exciting! Let's run some release tests to validate. Thankks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for @can-anyscale to review
ray.train.xgboost/lightgbm
(5/n): Remove xgboost_ray
and lightgbm_ray
dependencies (for releaase tests)ray.train.xgboost/lightgbm
(5/n): Remove xgboost_ray
and lightgbm_ray
dependencies (for release tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing lint; do you want to run some release tests to validate the changes as well, thankks
…ve_xgb_lgbm_ray_release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @woshiyyya @matthewdeng I am removing these for now because they're just testing |
The remaining https://buildkite.com/ray-project/release/builds/9540#018dec19-aae3-4d0b-9368-0504d37b7d72 |
Why are these changes needed?
This PR removes release tests for the external
xgboost_ray
andlightgbm_ray
packages that are no longer used by the new implementation ofXGBoostTrainer
andLightGBMTrainer
. See #42767 and #43244 for more details on the new implementations.air_benchmark_xgboost_cpu_10
is the only release test that actually testsXGBoostTrainer
, which has been kept around. TODO: A follow-up PR will add 2 more release tests (for each framework) to add back test coverage: a training and a tuning release test that usesXGBoostTrainer
/LightGBMTrainer
in a multi-node cluster.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.