Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing segfaults in Async Streaming Generator #43775

Merged
merged 18 commits into from
Mar 9, 2024
Merged

Fixing segfaults in Async Streaming Generator #43775

merged 18 commits into from
Mar 9, 2024

Commits on Mar 8, 2024

  1. Added reset_event_loop_executor method; 

    Tidying up

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    dfaed78 View commit details
    Browse the repository at this point in the history

  2. Shutdown currently running TPE to make sure there are no dangling tas… 

    …ks after this method returns

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6043847 View commit details
    Browse the repository at this point in the history

  3. Added regression test 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    818156f View commit details
    Browse the repository at this point in the history

  4. (XXX) Malloc vector (to trigger SIGSEGV) 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    33c6763 View commit details
    Browse the repository at this point in the history

  5. Extracting executor overriding sequence to run in ctor 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    49aea03 View commit details
    Browse the repository at this point in the history

  6. lint 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    72f98ff View commit details
    Browse the repository at this point in the history

  7. Added comments 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c21e4fb View commit details
    Browse the repository at this point in the history

  8. Tidying up 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    33b22fb View commit details
    Browse the repository at this point in the history

  9. lint 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3240770 View commit details
    Browse the repository at this point in the history

  10. Wait for executor shutdown in stop_and_join_asyncio_threads_if_exist 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    505d141 View commit details
    Browse the repository at this point in the history

  11. Tidying up 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    edf7a61 View commit details
    Browse the repository at this point in the history

  12. Revert resetting/shutting down the executor; 

    Replaced it with cooperative cancellation (using threading.Event)

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8030b15 View commit details
    Browse the repository at this point in the history

  13. Revert "(XXX) Malloc vector (to trigger SIGSEGV)" 

    This reverts commit 3d8b154.

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a27955a View commit details
    Browse the repository at this point in the history

  14. Adding test file to BUILD.bazel 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    38c6efe View commit details
    Browse the repository at this point in the history

  15. Tidying up 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    d684632 View commit details
    Browse the repository at this point in the history

  16. Fixing after rebase 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    ee598e1 View commit details
    Browse the repository at this point in the history

  17. Restored method to reset event-loop executor (for testing) 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    976859b View commit details
    Browse the repository at this point in the history

  18. Adding missing epilogue into test 

    Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
    @alexeykudinkin
    alexeykudinkin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4ffe396 View commit details
    Browse the repository at this point in the history