-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data][train] Update "Data Loading and Preprocessing" doc #44165
Conversation
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending fixing docs/premerge failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct any subjects that I added to convert passive voice sentences to active voice.
Also, consider using Vale to catch spelling and style errors. (go/vale)
@@ -71,6 +72,9 @@ Data ingestion can be set up with four basic steps: | |||
# Step 4: Access the dataset shard for the training worker via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation and step order looks wrong. This should be step 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from runtime's perspective, this happens after the step 3 below
Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
…t#44165) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
…t#44165) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
…t#44165) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.