[RLlib] Implementation of MultiAgentEpisodeReplayBuffer for the new API stack.
#44450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i_agent_episode_add_module_for_api
…i_agent_episode_add_slice_api
…d 'add' method. Fixed a minor bug in the 'MultiAgentEpisode' b/c the 'agent_module_ids' mapping was not assigned in the 'MultiAgentEpisode.__init__'. Furthermore, added some tests for the new buffer. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
… either 'independent' or 'synchronized'. There appears to be an inconsistency between the action getters of the SingleAgentEpisode' and the 'MultiAgentEpisode' - the latter retrieves the timestep one earlier than observations. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
sven1977
changed the title
MultiAgentEpisodeReplayBuffer for the new API stack.
sven1977
requested review from
sven1977,
avnishn,
ArturNiederfahrenhorst,
maxpumperla and
kouroshHakha
as code owners
sven1977
reviewed
Apr 3, 2024
sven1977
reviewed
Apr 3, 2024
sven1977
reviewed
Apr 3, 2024
sven1977
reviewed
Apr 3, 2024
rllib/utils/replay_buffers/multi_agent_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Apr 3, 2024
rllib/utils/replay_buffers/multi_agent_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Apr 3, 2024
rllib/utils/replay_buffers/multi_agent_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Apr 3, 2024
rllib/utils/replay_buffers/multi_agent_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Apr 3, 2024
|
|
||
| # Stores indices of module (single-agent) timesteps. | ||
| self._module_indices: Dict[str, List[Tuple[int]]] = defaultdict(list) | ||
| # Stores for each module the episode indices. |
There was a problem hiding this comment.
Same: improve typehint to DefaultDict[ModuleID, Dict[EpisodeID, int]] ? Is int correct here or should this be a 4-tuple as well?
Let's also above declare what "index" means throughout this entire class:
Something like:
"In this class, we use a global indexing system, where an individual index is a 4-tuple, consisting of 1) ...2)... 3)... 4) ..."
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
…i_agent_episode_add_slice_api
…api' into multi-agent-episode-replay-buffer Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
… and 'SingleAgentEpisode'. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…ays1980/ray into multi-agent-episode-replay-buffer Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…a buffer. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…ts for getters and counters. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…ixed. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
sven1977
reviewed
Apr 8, 2024
rllib/BUILD
Outdated
| @@ -1524,6 +1524,13 @@ py_test( | |||
| srcs = ["utils/replay_buffers/tests/test_episode_replay_buffer.py"] | |||
| ) | |||
|
|
|||
| oy_test( | |||
sven1977
approved these changes
Apr 8, 2024
sven1977
reviewed
Apr 8, 2024
Signed-off-by: Sven Mika <sven@anyscale.io>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…ays1980/ray into multi-agent-episode-replay-buffer Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…ts that depend on it. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
… the test for synchronized sampling'. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
With the new API stack and the
EnvRunner APIcame the necessity to define new replay buffers that can work completely on episode objects and stores the latter. This PR proposes the multi-agent version of theseEpisodeReplayBuffers.Sampling works in
independentandsynchronizedreplay mode and can use differentn-stepfor each item.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.