Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Implementation of MultiAgentEpisodeReplayBuffer for the new API stack. #44450

Merged
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
b16ab62
wip
sven1977 Mar 22, 2024
72a4bb5
Merge branch 'master' of https://github.com/ray-project/ray into mult…
sven1977 Mar 22, 2024
9b60b8c
wip
sven1977 Mar 22, 2024
297b711
wip
sven1977 Mar 22, 2024
eb6d04c
wip
sven1977 Apr 2, 2024
3819712
wip
sven1977 Apr 2, 2024
2cebf0b
merge
sven1977 Apr 2, 2024
3a009c8
merge
sven1977 Apr 2, 2024
05d8610
Merge branch 'master' of https://github.com/ray-project/ray into mult…
sven1977 Apr 3, 2024
11ee869
wip
sven1977 Apr 3, 2024
559f90d
wip
sven1977 Apr 3, 2024
8db92d7
wip
sven1977 Apr 3, 2024
fc4dc53
Defined 'MultiAgentEpisodeReplayBuffer' class and added '__init__' an…
simonsays1980 Apr 3, 2024
050b445
Defined 'sample' method for 'MultiAgentEpisodeReplayBuffer' to sample…
simonsays1980 Apr 3, 2024
38e68cf
Merge branch 'master' into multi-agent-episode-replay-buffer
sven1977 Apr 3, 2024
92ed1d7
wip
sven1977 Apr 3, 2024
db3259b
wip
sven1977 Apr 4, 2024
4c0195e
Merge branch 'master' of https://github.com/ray-project/ray into mult…
sven1977 Apr 4, 2024
e3b8468
unit tests passing
sven1977 Apr 4, 2024
2b8c1de
LINT
sven1977 Apr 4, 2024
b08bb21
unit tests passing, incl. MAEpisode slice fix for scenario with one a…
sven1977 Apr 4, 2024
007a140
fix `finalized` problem
sven1977 Apr 4, 2024
e5e2bf3
add proper terminateds/truncateds support to slicing.
sven1977 Apr 4, 2024
403c541
LINT
sven1977 Apr 4, 2024
d01f6b0
doctest fix
sven1977 Apr 4, 2024
d9eec24
Merge branch 'master' of https://github.com/ray-project/ray into mult…
sven1977 Apr 4, 2024
c6f0323
Merge remote-tracking branch 'sven1977/multi_agent_episode_add_slice_…
simonsays1980 Apr 4, 2024
d3e2263
Added review from @sven1977 and merged changes in 'MultiAgentEpisode'…
simonsays1980 Apr 4, 2024
fdaa40b
LINTER.
simonsays1980 Apr 4, 2024
4f9e991
Merge branch 'multi-agent-episode-replay-buffer' of github.com:simons…
simonsays1980 Apr 4, 2024
624ad91
Merge branch 'master' into multi-agent-episode-replay-buffer
simonsays1980 Apr 5, 2024
1188c36
Added getter for metrics and 'get/set_state' for pickling or storing …
simonsays1980 Apr 8, 2024
68a287c
Merged master.
simonsays1980 Apr 8, 2024
1d4d535
Refactored getters to override super's getters. In addition added tes…
simonsays1980 Apr 8, 2024
45c5164
Commented out sampling tests until getters in MultiAgentEpisode are f…
simonsays1980 Apr 8, 2024
df045e3
Apply suggestions from code review
sven1977 Apr 8, 2024
a2e9339
Added 'MultiAgentEpisodeReplayBuffer' to the list of registered buffers.
simonsays1980 Apr 8, 2024
deea2f7
Merge branch 'multi-agent-episode-replay-buffer' of github.com:simons…
simonsays1980 Apr 8, 2024
372d804
Added a 'concat_episode' method to MAE and fixed some testing logic.
simonsays1980 Apr 8, 2024
5108914
Fixed some minor bugs in the tests.
simonsays1980 Apr 9, 2024
4313a78
Merged master
simonsays1980 Apr 15, 2024
ce8628a
Merged master with new 'MultiAGentEpisode.concat' and uncommented tes…
simonsays1980 Apr 15, 2024
94a931e
Added @sven1977's fix in the 'InfiniteLookbackBuffer' and uncommented…
simonsays1980 Apr 23, 2024
a3664cc
Merge branch 'master' into multi-agent-episode-replay-buffer
simonsays1980 Apr 23, 2024
daf9507
Fixed remaining bugs in tests.
simonsays1980 Apr 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rllib/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1524,6 +1524,13 @@ py_test(
srcs = ["utils/replay_buffers/tests/test_episode_replay_buffer.py"]
)

oy_test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> py_test

sven1977 marked this conversation as resolved.
Show resolved Hide resolved
name = "test_multi_agent_episode_replay_buffer",
tags = ["team:rllib", "utils"],
size = "small",
srcs = ["utils/replay_buffers/tests/test_multi_agent_episode_replay_buffer.py"]
)

py_test(
name = "test_multi_agent_mixin_replay_buffer",
tags = ["team:rllib", "utils"],
Expand Down
2 changes: 1 addition & 1 deletion rllib/env/multi_agent_episode.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def __init__(
# via the `module_for()` API even before the agent has entered the episode
# (and has its SingleAgentEpisode created), we store all aldeary done mappings
# in this dict here.
self._agent_to_module_mapping: Dict[AgentID, ModuleID] = {}
self._agent_to_module_mapping: Dict[AgentID, ModuleID] = agent_module_ids or {}
simonsays1980 marked this conversation as resolved.
Show resolved Hide resolved

# Lookback buffer length is not provided. Interpret all provided data as
# lookback buffer.
Expand Down
Loading
Loading