[RLlib] Fix frame stacking connector for experiments with more than 1 Learner. #45588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dqn_multi_agent_debugging
Signed-off-by: sven1977 <svenmika1977@gmail.com>
…dqn_multi_agent_debugging
…dqn_multi_agent_debugging
…ti_agent_debugging
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
simonsays1980
approved these changes
May 28, 2024
| self, | ||
| stats_dicts, | ||
| stats_dicts: List[Dict[str, Any]], |
There was a problem hiding this comment.
This is already committed in the other PR today?
There was a problem hiding this comment.
Ah, yes, very sorry. I had to make sure the other PR (MetricsLogger log_n_dicts() fix) is also in here otherwise, the Atari benchmark would have failed.
Thanks for pointing this out.
sven1977
added
bug
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
… Learner. (ray-project#45588) Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
… Learner. (ray-project#45588) Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix frame stacking connector for experiments with more than 1 Learner.
The bug was that in
SingleAgentEpisode.slice(), which the LearnerGroup has to do in order to slice the received episodes in n shards to be sent to the n Learners, we would NOT properly set the observation/action spaces in the returned slices. This then lead to an incorrect fill-value (shape=1D instead of Atari 4D) for the left edges of the episodes (framestacking at the first m episodes timesteps needs to be left-0-padded), wherem = num_frames - 1.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.